fix: Fix #123 Password Validation Error on Signup #124
Conversation
Codecov Report
@@ Coverage Diff @@
## master #124 +/- ##
=======================================
Coverage 53.39% 53.39%
=======================================
Files 55 55
Lines 2358 2358
Branches 253 253
=======================================
Hits 1259 1259
Misses 1025 1025
Partials 74 74
Continue to review full report at Codecov.
|
mtahafarooq
changed the title
| @@ -1,7 +1,7 @@ | |||
| <div class="signup-container"> | |||
| <app-input [isRequired]="true" [label]="'Username'" [type]="'text'" [theme]="'dark'" [icon]="'assets/images/username_dark.png'" #formsignup></app-input> | |||
| <app-input [isRequired]="true" [label]="'Email'" [type]="'email'" [theme]="'dark'" [icon]="'assets/images/envelope_dark.png'" #formsignup></app-input> | |||
| <app-input [isRequired]="true" [label]="'Password'" [type]="'password'" [theme]="'dark'" [icon]="'assets/images/password_dark.png'" #formsignup></app-input> | |||
| <app-input [isRequired]="true" [label]="'Password1'" [type]="'password'" [theme]="'dark'" [icon]="'assets/images/password_dark.png'" #formsignup></app-input> | |||
There was a problem hiding this comment.
Please elaborate a bit about these changes. Also let us know other scenarios like alphabet only, Capital letter, special character etc.
There was a problem hiding this comment.
I've checked other scenarios and it's breaking on entirely numeric password for me.
So, when the password is entirely numeric the server returns the error with the key "password1", now the problem is that there's a function called formValueForLabel whose job is to fetch the form field against the given key, since the submission has failed and we're in the error handling part, when given "password1" as the key the function fails to fetch the field since the label of the field is "password" and not "password1". That's why the error was not showing for entirely numeric password.
There was a problem hiding this comment.
|
Hi @mtahafarooq, are you working on this or @RishabhJain2018 we could close this? |
|
Also, @Sanji515 @sanketbansal share your thoughts about this PR changes. Are you aware of this issue? |
|
I think this PR can be closed as @sanketbansal has build the authentication pages a/c to the current version of EvalAI so I think he have taken care of all these cases and if not then these all can be done in that PR |
Fixes #123
Changes proposed in this pull request: